-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13138/#review24377
-----------------------------------------------------------

Ship it!


Ship It!


helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java
<https://reviews.apache.org/r/13138/#comment48224>

    can we change the name of this state model, the naming is really bad. Its 
actually a fully replicated state model which means every node in the cluster 
holds the same data. I think FullyReplicated is a better name


- Kishore Gopalakrishna


On July 31, 2013, 9:36 p.m., Zhen Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13138/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 9:36 p.m.)
> 
> 
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi 
> Lu.
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> schemata state model test should use ANY_LIVEINSTANCE as preference list. 
> refector the test to start a new instance after cluster is stabilized and 
> make sure it goes to MASTER state
> 
> 
> Diffs
> -----
> 
>   helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java 
> e5e8d47 
> 
> Diff: https://reviews.apache.org/r/13138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhen Zhang
> 
>

Reply via email to