On Wed, Jul 31, 2013 at 10:16 AM, kishore g <[email protected]> wrote: > Hi Pat, > > Do you know how patches are reviewed and applied in other projects. We want > to enforce review and then commit policy for Helix. I am looking at some > best practices out there.
Depends on the project. Many projects in the lucene lineage (e.g. hadoop/zk/hive/pig/...) use jira attachments (patches) for submission/tracking. contributors submit the patch via jira and committers review/commit to svn. Only committers can commit code to svn at apache. These tend to be RTC based projects. Some projects use CTR, which is also fine. Tends to result in faster development. However sometimes things can get in before they get proper review. The community needs to keep an eye on commits and look for issues. (often the case regardless) I like RTC via jira because it makes things easier to track. It tends to be a slower process though... Patrick
