> On Aug. 2, 2013, 4:50 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java, > > line 238 > > <https://reviews.apache.org/r/13209/diff/1/?file=333789#file333789line238> > > > > move this to a function (replica.hashCode() & 0x7FFFFFFF) % > > _liveNodesList.size(). I think its used in other places as well.
Done. > On Aug. 2, 2013, 4:50 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java, > > line 254 > > <https://reviews.apache.org/r/13209/diff/1/?file=333789#file333789line254> > > > > can we have a function transfer(donor,receiver,replica) or we can have > > a method on the Node like steal(donor,replica) Done. > On Aug. 2, 2013, 4:50 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java, > > line 212 > > <https://reviews.apache.org/r/13209/diff/1/?file=333789#file333789line212> > > > > have the check for added and it.remove at once place. Done. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13209/#review24537 ----------------------------------------------------------- On Aug. 2, 2013, 12:34 a.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13209/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 12:34 a.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-151 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-151. Previously, nodes 0 to k were given ceiling capacity with > respect to the number of replicas divided by number of nodes and nodes k+1 to > n-1 were given floor capacity. This allows orphan replicas to live on nodes > with floor capacity if a node with ceiling capacity is able to donate a unit > of capacity. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 740d17d > > Diff: https://reviews.apache.org/r/13209/diff/ > > > Testing > ------- > > Ran the end-to-end randomized test for the auto rebalancing strategy. > > > Thanks, > > Kanak Biscuitwala > >
