----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13250/#review24601 -----------------------------------------------------------
Ship it! helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java <https://reviews.apache.org/r/13250/#comment48639> can you use the stat to make sure, no one else has changed it. we need to be doubly sure while updating a ephemeral node. helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java <https://reviews.apache.org/r/13250/#comment48638> isn't this a bug to createPersistent liveInstance node ? - Kishore Gopalakrishna On Aug. 2, 2013, 11:43 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13250/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 11:43 p.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > add a test for consecutive zk session expiry handling. fix a bug in > ParticipantManager#handleNewSession() > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > 4f9d138 > helix-core/src/test/java/org/apache/helix/ZkTestHelper.java 37b0664 > > helix-core/src/test/java/org/apache/helix/integration/manager/MockParticipantManager.java > dccad56 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java > e69de29 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java > a35a49d > > helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java > 9ace407 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockMSModelFactory.java > 02bfb46 > > Diff: https://reviews.apache.org/r/13250/diff/ > > > Testing > ------- > > all tests pass locally > > > Thanks, > > Zhen Zhang > >
