----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13390/ -----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. Bugs: HELIX-173 Repository: helix-git Description ------- Fix for HELIX-173. Right now, the code to compute mappings from partitions to nodes and states is mostly in a single file, regardless of the rebalancing mode. Moving these operations cleans up the code and is more logical for pluggable rebalancers. Diffs ----- helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/rebalancer/Rebalancer.java 62a73b3 helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74 helix-core/src/main/java/org/apache/helix/controller/stages/util/BestStateCalculator.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937 helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 50a2f81 helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java df32c4e Diff: https://reviews.apache.org/r/13390/diff/ Testing ------- Tests pass locally. Thanks, Kanak Biscuitwala
