----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13611/#review25258 -----------------------------------------------------------
Instead of having these checks in different places, can we have a method that converts one mode to another in the beginning, basically have something like idealstate standardizeIdealState(idealstate) that always populates the new rebalancermode helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java <https://reviews.apache.org/r/13611/#comment49555> why not use idealstate.getrebalancerclass, i think getRecord should also be removed from Helixproperty to restrict usage of znrecord outside of model class helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java <https://reviews.apache.org/r/13611/#comment49556> same as above - Kishore Gopalakrishna On Aug. 16, 2013, 12:50 a.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13611/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 12:50 a.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-205 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-205. HELIX-166 introduced a new mode for user-defined > rebalancers, so this change starts using that mode directly. For the most > part, this follows most semi-auto rebalancer code paths (as it has been up > this point). > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java > 79e957c > > helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java > a049fef > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java > a9226d3 > helix-core/src/main/java/org/apache/helix/model/IdealState.java 22e2328 > > helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java > 1d34e5b > > Diff: https://reviews.apache.org/r/13611/diff/ > > > Testing > ------- > > Tests passing locally. > > > Thanks, > > Kanak Biscuitwala > >
