----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13930/#review25832 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/tools/YAMLClusterSetup.java <https://reviews.apache.org/r/13930/#comment50394> can you add this as a standalone utility by adding an entry to pom.xml programs xml fragment? recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockFactory.java <https://reviews.apache.org/r/13930/#comment50389> add documentation here, say that this will be invoked exactly once per lock on each participant. All further transitions will be invoked on this instance of Lock. recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockManagerRebalancer.java <https://reviews.apache.org/r/13930/#comment50393> Add documentation here, tell that this will be invoked every time there is a change in cluster, new participant joins/leaves etc recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockManagerRebalancer.java <https://reviews.apache.org/r/13930/#comment50391> For this example, dont use statecount as R instead set it as 1. so that you can avoid the if condition. recipes/user-rebalanced-lock-manager/src/main/resources/lock-manager-config.yaml <https://reviews.apache.org/r/13930/#comment50395> can you call the package userdefinedrebalancer - Kishore Gopalakrishna On Sept. 1, 2013, 10:42 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13930/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2013, 10:42 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-215 > > > Repository: helix-git > > > Description > ------- > > Website documenting all this is in progress. > > commit 75d28df74db2c5cf6eeff60badd44189d7e4bf0c > Author: Kanak Biscuitwala <[email protected]> > Date: Sun Sep 1 15:34:47 2013 -0700 > > [HELIX-215] YAML-based configuration, new recipe that uses YAML and > USER_DEFINED rebalancer > > :100644 100644 af04d85... 3607ab2... M helix-core/pom.xml > :000000 100644 0000000... c7233ed... A > helix-core/src/main/java/org/apache/helix/tools/YAMLClusterSetup.java > :100644 100644 ee6f573... 6840410... M pom.xml > :100644 100644 d0a93b1... 89d2ee5... M recipes/pom.xml > :000000 100644 0000000... 4364d5c... A > recipes/user-rebalanced-lock-manager/README.md > :000000 100644 0000000... 26682f4... A > recipes/user-rebalanced-lock-manager/pom.xml > :000000 100644 0000000... 4b3dc31... A > recipes/user-rebalanced-lock-manager/src/main/config/log4j.properties > :000000 100644 0000000... d91ec5c... A > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/Lock.java > :000000 100644 0000000... add56b1... A > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockFactory.java > :000000 100644 0000000... 18e7964... A > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockManagerDemo.java > :000000 100644 0000000... 457a909... A > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockManagerRebalancer.java > :000000 100644 0000000... 0929459... A > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockProcess.java > :000000 100644 0000000... e391a1d... A > recipes/user-rebalanced-lock-manager/src/main/resources/lock-manager-config.yaml > :000000 100644 0000000... 58f0803... A > recipes/user-rebalanced-lock-manager/src/test/conf/testng.xml > > > Diffs > ----- > > helix-core/pom.xml af04d85 > helix-core/src/main/java/org/apache/helix/tools/YAMLClusterSetup.java > PRE-CREATION > pom.xml ee6f573 > recipes/pom.xml d0a93b1 > recipes/user-rebalanced-lock-manager/README.md PRE-CREATION > recipes/user-rebalanced-lock-manager/pom.xml PRE-CREATION > recipes/user-rebalanced-lock-manager/src/main/config/log4j.properties > PRE-CREATION > > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/Lock.java > PRE-CREATION > > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockFactory.java > PRE-CREATION > > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockManagerDemo.java > PRE-CREATION > > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockManagerRebalancer.java > PRE-CREATION > > recipes/user-rebalanced-lock-manager/src/main/java/org/apache/helix/userrebalancedlocks/LockProcess.java > PRE-CREATION > > recipes/user-rebalanced-lock-manager/src/main/resources/lock-manager-config.yaml > PRE-CREATION > recipes/user-rebalanced-lock-manager/src/test/conf/testng.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/13930/diff/ > > > Testing > ------- > > The recipe works just like the original distributed lock manager. > > > Thanks, > > Kanak Biscuitwala > >
