> On Oct. 4, 2013, 6:24 a.m., Kanak Biscuitwala wrote: > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkClient.java, line 141 > > <https://reviews.apache.org/r/14483/diff/1/?file=361295#file361295line141> > > > > Seems a little hacky to have this logic in a catch block. Should we > > rely on the super implementation at all?
currently we need to rely on the super implementation because we don't have access to the private ZkClient#_eventThread. We are going to remove zkclient dependency, which will solve this problem directly. > On Oct. 4, 2013, 6:24 a.m., Kanak Biscuitwala wrote: > > helix-core/src/test/java/org/apache/helix/ZkTestHelper.java, line 115 > > <https://reviews.apache.org/r/14483/diff/1/?file=361296#file361296line115> > > > > remove whitespace done > On Oct. 4, 2013, 6:24 a.m., Kanak Biscuitwala wrote: > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java, > > line 83 > > <https://reviews.apache.org/r/14483/diff/1/?file=361297#file361297line83> > > > > Remove these todos done - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14483/#review26661 ----------------------------------------------------------- On Oct. 4, 2013, 5:37 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14483/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 5:37 a.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > If we close zkclient inside its own event thread context, we will get a > ZkInterruptedException and ZkConnection#close() will be skipped. The > workaround catches this ZkInterruptedException and does the > ZkConnection#close(). One tricky point is inside ZkInterruptedException > constructor, current thread is being interrupted again, so we need to clear > interrupted status of current state and safely do the ZkConnection#close. > After that, we need to restore the interrupted status of current thread. > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkClient.java 5b3af6d > helix-core/src/test/java/org/apache/helix/ZkTestHelper.java db2a6d0 > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java > e69de29 > > Diff: https://reviews.apache.org/r/14483/diff/ > > > Testing > ------- > > TestZkFlapping > > > Thanks, > > Zhen Zhang > >
