----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15440/#review28714 -----------------------------------------------------------
Ship it! Can you verify that LogicalModelExample in helix-examples runs without any errors? - Kanak Biscuitwala On Nov. 11, 2013, 4:54 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15440/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 4:54 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-296] HelixConnection in 0.7.0 does not remove LiveInstance znode > adding all missing apache license headers for helix connection classes > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/HelixAutoController.java 7ad9218 > helix-core/src/main/java/org/apache/helix/HelixConnection.java 7551673 > helix-core/src/main/java/org/apache/helix/HelixConnectionStateListener.java > 13172d0 > helix-core/src/main/java/org/apache/helix/HelixController.java ce47e3d > helix-core/src/main/java/org/apache/helix/HelixParticipant.java 9002b15 > helix-core/src/main/java/org/apache/helix/HelixRole.java 9e112d1 > helix-core/src/main/java/org/apache/helix/HelixService.java 33cc8e5 > > helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java > 869563a > helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackHandler.java > e69de29 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkClient.java 4fd7a9a > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java > d9ea445 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > 0717d77 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java > b0c5a8b > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > 06e8cd8 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > eba96c9 > helix-core/src/main/java/org/apache/helix/monitoring/StatusDumpTask.java > 751aefa > > helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactory.java > 770bba4 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactoryAdaptor.java > a17d9f3 > > helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java > 43e0250 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAutoController.java > e69de29 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixController.java > e69de29 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixParticipant.java > e69de29 > > Diff: https://reviews.apache.org/r/15440/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
