----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16407/ -----------------------------------------------------------
(Updated Dec. 23, 2013, 3:10 p.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Changes ------- I tried the suggested approach, but found that it did not significantly decrease the latency and made the code much more difficult to read (lots of type conversions and helper data structures since each thing could be a different HelixProperty under a different path). What I settled on was caching messages, batch-reading all current states, and leaving everything else alone. The performance is still improved, but not at the expense of readability/maintainability. Bugs: HELIX-345 Repository: helix-git Description ------- commit 90e995b02a59622a0526897faaee3d6ae057b63e Author: Kanak Biscuitwala <[email protected]> Date: Thu Dec 19 15:44:48 2013 -0800 [HELIX-345] Speed up the controller pipeline for 0.6.x :100644 100644 5c0a94a... 5858958... M helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java :100644 100644 df893bb... 9e2452b... M helix-core/src/test/java/org/apache/helix/Mocks.java Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java 5c0a94a helix-core/src/test/java/org/apache/helix/Mocks.java df893bb Diff: https://reviews.apache.org/r/16407/diff/ Testing ------- Tests pass locally, ReadClusterDataStage finishes 10-20% faster in extreme cases. Thanks, Kanak Biscuitwala
