I thought we no longer need to run any script in docker entrypoint. Is the heron install script still required by some reason? I can't find the script in my built image. heron binary is by default installed and ready to run.
Regards J, Windham Wong OSWE, OSCP, GCIA, Specialist in Cybersecurity Co-Founder, Managing Partner of Stormeye.io, Hong Kong Managed Security Operation Center Limited Specialist in Cybersecurity, Log Management and SIEM System Email // [email protected] (mailto:[email protected]) Phone // +852_3590_2212_|_+852_9832_0707 (tel:+85235902212) Fax // +852_3590_2202 (tel:+852_3590_2202) On 3月 25 2021, at 6:39 早上, Josh Fischer <[email protected]> wrote: > I should have worded my last email better. Really I should have asked for > recommendations on what should be done. As of late I've been more involved > in the Apache side of things and less in the code for Heron. > > A requirement for the tar.gz and install script files is that they contain > the disclaimers required by the incubator for a legitimate release. > > For the tar.gz file: > I think we can easily add those files manually for this release. From here > (If I remember correctly) and nicks email that there is a way to create a > docker image without the need of an install script. Basically you run the > command mounting it over a tar.gz file and it installs the files to the > appropriate spots. The followling link explains it I think > https://github.com/apache/incubator-heron/tree/master/docker. > > For the install scripts: > We need to include the disclaimers into the install scripts so that when > someone runs ".heron-install.sh" the DISCLAIMER, NOTICE and LICENSE files > are all installed into the users machine. It is explained better by Dave in > this email here > https://lists.apache.org/thread.html/rddeea15441d1ecb57072ce94c0d3711bf3c1ec99d56076d1d83f4e66%40%3Cdev.heron.apache.org%3E > > However, to include these disclaimers into the install scripts we will need > to modify some of the source code (I imagine) that is part of the Heron > release. > > I'm thinking of taking small steps here. I don't think we will need to > change anything to create the docker image once we have a Debian binary > package with disclaimers included. Then we can follow up with another > release that addresses adding disclaimers into the install scripts and > potentially adding another Heron docker image (centos). I don't think we > can release CentOS yet as the docker container would contain binaries that > are Category X (1). > > 1. https://apache.org/legal/resolved.html#category-x > > > > On Wed, Mar 24, 2021 at 12:14 PM Nicholas Nezis <[email protected]> > wrote: > > > Josh, > > > > Not sure if this helps, but I think we've already done the work to remove > > the heron install script from the resulting image. We're now using the > > newer Docker build features that allow for mounting in files from the > > docker context that don't need to be in the final image. > > > > > > https://github.com/apache/incubator-heron/blob/c23dba7a5d6982d38bb786fb54462bfa51688929/docker/dist/Dockerfile.dist.debian10#L35 > > > > Also Debian seems ok, but I'll say that we're currently using Centos for > > our production system, so I'll probably just need to continue building my > > own image. Which with the build-artifact.sh and build-docker.sh scripts, > > it's very easy. So not an issue. > > > > Nick > > > > On Wed, Mar 24, 2021 at 12:54 PM Ning Wang <[email protected]> wrote: > > > > > "removing the install scripts from the release"? Which one? It blocks the > > > creation of the docker image? > > > > > > On Wed, Mar 24, 2021 at 9:41 AM Josh Fischer <[email protected]> > > wrote: > > > > > > > Hi, > > > > > > > > I had an official Docker repo for Heron created under the Apache > > > > Foundation. You can find it below: > > > > > > > > https://hub.docker.com/repository/docker/apache/heron > > > > > > > > I did some thinking on the newest Heron release binaries > > > > (0.20.3-incubating) and what needs to be done. I'm thinking of > > > > removing the install scripts from the release and only focus on the > > > Debian > > > > tar.gz compiled binaries. The reason for this is so that we can take > > > this > > > > binary and use it to create our first Apache Heron Docker Image. I > > think > > > > we will need to do some additional work to support the adding > > disclaimers > > > > to the install scripts. Any thoughts, comments, or concerns? > > > > > > > > > > > > - Josh > > > > > > > > > > > > On Tue, Mar 23, 2021 at 12:07 PM Ning Wang <[email protected]> > > wrote: > > > > > > > > > Hello, > > > > > > > > > > It has been two weeks since our last sync! Let's share our works for > > > the > > > > > last two weeks in this thread. Thanks! > > > > > > > > > > > > > > > Regards, > > > > > --ning > > > > > > > > > > > > > > >
