surahman commented on code in PR #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r841271672
##########
heron/instance/src/python/utils/metrics/py_metrics.py:
##########
@@ -80,7 +80,7 @@ def __init__(self, metrics_collector):
PY_GC_GENERATION_1_THRESHOLD: self.g1_threshold,
PY_GC_GENERATION_2_THRESHOLD: self.g2_threshold,
PY_GC_GENERATION_3_THRESHOLD: self.g3_threshold}
- super(PyMetrics, self).__init__(self.metrics)
+ _ = super()
Review Comment:
This syntax is analogous to what we have in Golang. I am essentially telling
the Python3 interpreter and linter "Yes, I am aware a value is returned from
this superclass constructor call. No, I do not need it, and yes I wish to
ignore it."
Some linters will output a warning about this and it could potentially
escalate to an error down the road. Let us not generate/leave technical debt to
be dealt with later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
