LGTM, great work! I think you should merge once the build pipeline completes and passes given Choi and you have done the deployment testing.
On Mon, Apr 11, 2022 at 11:31 AM Nicholas Nezis <[email protected]> wrote: > Ok, I think the Pull Request fixing the various Heron UI and Tracker issues > is finally complete. Last call for reviews before I merge later today. > > https://github.com/apache/incubator-heron/pull/3786 > > On Fri, Mar 25, 2022 at 6:01 PM Ning Wang <[email protected]> wrote: > > > option 1 seems better to me > > > > On Fri, Mar 25, 2022 at 2:50 PM Saad Ur Rahman <[email protected]> > > wrote: > > > > > > > > https://github.com/apache/incubator-heron/pull/3786#issuecomment-1079456640 > > > I think we can switch over to using just the HTTP status codes. > > > > > > On Fri, Mar 25, 2022 at 1:21 PM Nicholas Nezis < > [email protected] > > > > > > wrote: > > > > > > > I'd like some input on this pull request that I'm currently working > on. > > > I'm > > > > resolving issues which we introduced when we updated to the newer > > Python > > > 3 > > > > and newer HTTP API frameworks like FastAPI. > > > > > > > > Specifically I need help with the question I posted in this comment. > > > There > > > > is a limitation in the FastAPI framework which made the current code > > not > > > > work. I'm fixing it by simplifying a perhaps outdated implementation > > for > > > > HTTP APIs. But I wanted some input. Is it better to keep the Response > > > > Evelope on the HTTP API calls? We weren't really using it. > > > > > > > > > > > > > > https://github.com/apache/incubator-heron/pull/3786#issuecomment-1079236798 > > > > > > > > Thanks, > > > > Nick > > > > > > > > > >
