Dave,

Are you suggesting we create a new RC with the fixes to the NOTICE and
missing ASF headers in the Python files before proceeding to [email protected]?

There has been some uncertainty amongst the community.




On Thu, May 19, 2022 at 9:18 AM Dave Fisher <[email protected]> wrote:

> Hi -
>
> Sent from my iPhone
>
> > On May 19, 2022, at 6:30 AM, Josh Fischer <[email protected]> wrote:
> >
> > Hey All,
> >
> > -1 on this RC
> >
> > I think we need a page that shows all of the commits for the
> > 0.20.5-incubating-rc2 tag [1].  I think we can mark this under the github
> > releases page [2] as a "pre-release" to get this ability.
>
> I don’t think this is a release blocker.
> >
> > 1.
> >
> https://github.com/apache/incubator-heron/releases/tag/0.20.5-incubating-rc2
> > 2. https://github.com/apache/incubator-heron/releases
> >
> > I checked:
> >
> > - Links are valid
> > - License is good
> > -  NOTICE Shows 2018  - 2021, not sure if this is a blocker for this
> > release or not.
>
> Not a blocker but if there is one then it should be 2022.
> > - Signatures & shasum are ok on src files. I did not check other files
> > because of possible issue with NOTICE file listed above ^
> > - DISCLAIMER exists
> >
> > We are missing ASF headers on these files:
> >
> > ./heron/tools/tracker/src/python/state.py
> >
> > ./heron/tools/tracker/tests/python/app_unittest.py
>
> Good catch fixing tgese before the VOTE goes to general helps with the
> heron graduation case
>
> >
> >> On Wed, May 11, 2022 at 11:50 PM Nicholas Nezis <
> [email protected]>
> >> wrote:
> >>
> >> Hello Heron Community,
> >>
> >> This is a call for a vote to the 2nd release candidate for Apache Heron,
> >> version 0.20.5-incubating.
> >> We request project mentors (binded) as well as all contributors
> (unbinded)
> >> and users to review and vote on this incubator release.
> >>
> >> *  The tag to be voted upon:
> >> dc2d9f675a85effcaa74cba6c8fff8451597e146
> >> The full list of changes and release notes are available at:
> >>
> >>
> https://github.com/apache/incubator-heron/releases/tag/0.20.5-incubating-rc2
> >>
> >> Files can be found in dist.apache.org
> >> Source:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-0.20.5-incubating-src.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-0.20.5-incubating-src.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-0.20.5-incubating-src.tar.gz.asc
> >>
> >> Java Artifacts:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-artifacts-0.20.5-incubating.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-artifacts-0.20.5-incubating.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-artifacts-0.20.5-incubating.tar.gz.asc
> >>
> >> Centos 7 Installer:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-centos7.sh.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-centos7.sh.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-centos7.sh.tar.gz.asc
> >>
> >> Darwin Installer:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-darwin.sh.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-darwin.sh.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-darwin.sh.tar.gz.asc
> >>
> >> Debian 11 Installer:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-debian11.sh.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-debian11.sh.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-debian11.sh.tar.gz.asc
> >>
> >> Ubuntu 20.04 Installer:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-ubuntu20.04.sh.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-ubuntu20.04.sh.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-install-0.20.5-incubating-ubuntu20.04.sh.tar.gz.asc
> >>
> >> HeronPy:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heronpy/heronpy-0.20.5-incubating.tar.gz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heronpy/heronpy-0.20.5-incubating.tar.gz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heronpy/heronpy-0.20.5-incubating.tar.gz.asc
> >>
> >> HeronPy Wheel:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heronpy/heronpy-0.20.5_incubating-py3-none-any.whl
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heronpy/heronpy-0.20.5_incubating-py3-none-any.whl.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heronpy/heronpy-0.20.5_incubating-py3-none-any.whl.asc
> >>
> >> Helm chart:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/helm/heron-0.20.5-incubating.tgz
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/helm/heron-0.20.5-incubating.tgz.sha512
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/helm/heron-0.20.5-incubating.tgz.asc
> >>
> >> Please download the source package, and follow the below steps from the
> >> root folder of the heron code base.  Note that currently Bazel 4.2.2 is
> >> required to build this version.
> >> # check that Bazel and other dependencies are setup correctly
> >> ./bazel_configure.py
> >>
> >>
> >> To build an install script for your desired platform (debian, and centos
> >> are supported for this release) you may run the following command.
> >> $ bazel build scripts/packages:binpkgs
> >>
> >> To execute and install Heron from an install script you can follow the
> >> steps below:
> >>
> >> $ chmod +x heron-install-0.20.5-incubating-{distro}.sh
> >> $ ./heron-install-0.20.5-incubating-{distro}.sh --user
> >>
> >> From here you should find disclaimers and other files in your ~/.heron
> >> directory.
> >> ls ~/.heron/
> >>
> >> DISCLAIMER    NOTICE        conf/         etc/          include/
> >> release.yaml
> >>
> >> LICENSE       bin/          dist/         examples/     lib/
> >>
> >>
> >> or refer to the compiling guide
> >> https://heron.incubator.apache.org/docs/next/compiling-overview/
> >> to setup the environment, build and run locally.
> >>
> >> After Bazel is set up and works correctly, you can use these release
> check
> >> scripts as well.
> >>
> >>
> https://github.com/apache/incubator-heron/blob/master/scripts/release_check/README.md#run-individual-release-checks
> >> to verify the build.  The vote will be open for at least 72 hours or
> until
> >> the necessary number of votes are reached.
> >>
> >> Please vote accordingly:
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thank you,
> >>
> >> The Apache Heron (Incubating) Team
> >>
> >> On Wed, May 11, 2022 at 5:23 PM Nicholas Nezis <
> [email protected]>
> >> wrote:
> >>
> >>> Awesome thanks. I'll get an email out shortly.
> >>>
> >>> On Wed, May 11, 2022 at 4:47 PM Dave Fisher <[email protected]>
> >> wrote:
> >>>
> >>>> Every artifact that is included in a release must have an asc and
> either
> >>>> a sha256 or sha512. The links need to be in the VOTE email. One of the
> >>>> criteria git a +1 is that these are checked and are valid.
> >>>>
> >>>> Sent from my iPhone
> >>>>
> >>>>> On May 11, 2022, at 1:30 PM, Nicholas Nezis <
> [email protected]
> >>>
> >>>> wrote:
> >>>>>
> >>>>> Josh, I'll update the email with fixed links and resend. I think
> >> when I
> >>>>> copied the prior RC1 email, I modified the text of the URL, but not
> >> the
> >>>>> underlying link.
> >>>>>
> >>>>> Dave, we didn't have the link to the KEYS file in the RC1 email. I'll
> >> be
> >>>>> sure to add it. For the asc link, should I be mentioning each asc
> file
> >>>> that
> >>>>> is present in the SVN dist repository? Or can I focus on specifically
> >>>>> mentioning the Source bundle (tar.gz, sha512 and asc files)?
> >>>>>
> >>>>> Ning, I made the tag, but didn't make the release in Github. I wasn't
> >>>> sure
> >>>>> about the process for that. In theory I can just click the "release"
> >>>> button
> >>>>> from the tag. I'll do that now if we feel that step should also be
> >> done
> >>>> at
> >>>>> this point.
> >>>>>
> >>>>>> On Wed, May 11, 2022 at 3:26 PM Ning Wang <[email protected]>
> >>>> wrote:
> >>>>>>
> >>>>>> Maybe the tag is not made public yet? It seems I don't see a rc2
> >>>> release in
> >>>>>> this page: https://github.com/apache/incubator-heron/releases/
> >>>>>>
> >>>>>> On Wed, May 11, 2022 at 1:38 AM Nicholas Nezis <
> >>>> [email protected]>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Hello Heron Community,
> >>>>>>>
> >>>>>>> This is a call for a vote to the 1st release candidate for Apache
> >>>> Heron,
> >>>>>>> version 0.20.5-incubating.
> >>>>>>> We request project mentors (binded) as well as all contributors
> >>>>>> (unbinded)
> >>>>>>> and users to review and vote on this incubator release.
> >>>>>>>
> >>>>>>> *  The tag to be voted upon:
> >> dc2d9f675a85effcaa74cba6c8fff8451597e146
> >>>>>>> The full list of changes and release notes are available
> >>>>>>> at:
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://github.com/apache/incubator-heron/releases/tag/0.20.5-incubating-rc
> >>>>>>> <
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://github.com/apache/incubator-heron/releases/tag/0.20.5-incubating-rc2
> >>>>>>>> 2
> >>>>>>>
> >>>>>>> Files can be found in dist.apache.org
> >>>>>>> Source:
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-0.20.5-incubating-src.tar.gz
> >>>>>>> SHA-512
> >>>>>>> <
> >>>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-0.20.5-incubating-src.tar.gzSHA-512
> >>>>>>>
> >>>>>>> checksums:
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc2/heron-0.20.5-incubating-src.tar.gz.sha512
> >>>>>>>
> >>>>>>>
> >>>>>>> Please download the source package, and follow the below steps from
> >>>>>>> the root folder of the heron code base.  Note that currently Bazel
> >>>>>>> 4.2.2 is required to build this version.
> >>>>>>> # check that Bazel and other dependencies are setup correctly
> >>>>>>> ./bazel_configure.py
> >>>>>>>
> >>>>>>>
> >>>>>>> To build an install script for your desired platform (debian, and
> >>>>>>> centos are supported for this release) you may run the following
> >>>>>>> command.
> >>>>>>> $ bazel build scripts/packages:binpkgs
> >>>>>>>
> >>>>>>> To execute and install Heron from an install script you can follow
> >> the
> >>>>>>> steps below:
> >>>>>>>
> >>>>>>>
> >>>>>>> $ chmod +x heron-install-0.20.5-incubating-{distro}.sh
> >>>>>>> $ ./heron-install-0.20.5-incubating-{distro}.sh --user
> >>>>>>>
> >>>>>>> From here you should find disclaimers and other files in your
> >> ~/.heron
> >>>>>>> directory.
> >>>>>>> ls ~/.heron/
> >>>>>>>
> >>>>>>> DISCLAIMER    NOTICE        conf/         etc/          include/
> >>>>>>> release.yaml
> >>>>>>>
> >>>>>>> LICENSE       bin/          dist/         examples/     lib/
> >>>>>>>
> >>>>>>>
> >>>>>>> or refer to the compiling
> >>>>>>> guidehttps://
> >> heron.incubator.apache.org/docs/next/compiling-overview/
> >>>>>>> to setup the environment, build and run locally.
> >>>>>>>
> >>>>>>> After Bazel is set up and works correctly, you can use these
> release
> >>>>>> check
> >>>>>>> scripts as well.
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://github.com/apache/incubator-heron/blob/master/scripts/release_check/README.md#run-individual-release-checks
> >>>>>>> to verify the build.  The vote will be open for at least 72 hours
> or
> >>>>>> until
> >>>>>>> the necessary number of votes are reached.
> >>>>>>>
> >>>>>>> Please vote accordingly:
> >>>>>>> [ ] +1 approve
> >>>>>>> [ ] +0 no opinion
> >>>>>>> [ ] -1 disapprove with the reason
> >>>>>>>
> >>>>>>> Thank you,
> >>>>>>>
> >>>>>>> The Apache Heron (Incubating) Team
> >>>>>>>
> >>>>>>
> >>>>
> >>>>
> >>
>
> --
Sent from A Mobile Device

Reply via email to