Hi,

I think this is a -1 from me.  I checked these items:
- Download links are not all valid [1]
- Checksums and signatures [1]
- LICENSE/NOTICE/DISCLAIMER files exist
- binary files in code base
  - a tar file exists in the rc folder: [2]
- All source files have ASF headers

1.
-
https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-artifacts-0.20.5-incubating.tar.gz
doesn't
exist, is this an accident or typo? but I see these files under the "maven"
folder and the signatures are good.
- Darwin installer sha512 link is incorrect, but the file does exist and
signature is good
- HeronPy files are named incorrectly and link is broken, but signatures
match
- HeronPy wheel files are also named incorrectly and link is broken, but
signatures match
- Helm chart files are also named incorrectly and link is broken, but
signatures match

2.
This binary file exists in the rc.
./heron/uploaders/tests/java/org/apache/heron/uploader/
localfs/testdata/some-topology.tar

On Sat, Jul 9, 2022 at 3:59 PM Nicholas Nezis <[email protected]>
wrote:

> Hello Heron Community,
>
> This is a call for a vote to the 4th release candidate for Apache Heron,
> version 0.20.5-incubating.
>
> We request project mentors (binded) as well as all contributors (unbinded)
> and users to review and vote on this incubator release.
>
> *  The tag to be voted upon: 12b8abc152f7a23e87ef19299ff92423a6ee1469
> The full list of changes and release notes are available
> at:
> https://github.com/apache/incubator-heron/releases/tag/0.20.5-incubating-rc4Files
> can be found in dist.apache.org
>
> KEYS <https://dist.apache.org/repos/dist/dev/incubator/heron/KEYS>
> Source:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-0.20.5-incubating-src.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-0.20.5-incubating-src.tar.gz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-0.20.5-incubating-src.tar.gz.asc
>
> Java Artifacts:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-artifacts-0.20.5-incubating.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-artifacts-0.20.5-incubating.tar.gz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-artifacts-0.20.5-incubating.tar.gz.asc
>
> Centos 7 Installer:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-centos7.sh.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-centos7.sh.tar.gz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-centos7.sh.tar.gz.asc
>
> Darwin Installer:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-darwin.sh.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-darwin.sh.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-darwin.sh.tar.gz.asc
>
> Debian 11 Installer:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-debian11.sh.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-debian11.sh.tar.gz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-debian11.sh.tar.gz.asc
>
> Ubuntu 22.04 Installer:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-ubuntu22.04.sh.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-ubuntu22.04.sh.tar.gz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heron-install-0.20.5-incubating-ubuntu22.04.sh.tar.gz.asc
>
> HeronPy:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heronpy/heronpy-0.20.5-incubating.tar.gz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heronpy/heronpy-0.20.5-incubating.tar.gz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heronpy/heronpy-0.20.5-incubating.tar.gz.asc
>
> HeronPy Wheel:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heronpy/heronpy-0.20.5_incubating-py3-none-any.whl
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heronpy/heronpy-0.20.5_incubating-py3-none-any.whl.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/heronpy/heronpy-0.20.5_incubating-py3-none-any.whl.asc
>
> Helm chart:
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/helm/heron-helm-0.20.5-incubating.tgz
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/helm/heron-helm-0.20.5-incubating.tgz.sha512
>
> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc4/helm/heron-helm-0.20.5-incubating.tgz.asc
>
>
>
> Please download the source package, and follow the below steps from
> the root folder of the heron code base.  Note that currently Bazel
> 4.2.2 is required to build this version.
> # check that Bazel and other dependencies are setup correctly
> ./bazel_configure.py
>
>
> To build an install script for your desired platform (debian, and
> centos are supported for this release) you may run the following
> command.
> $ bazel build scripts/packages:binpkgs
>
> To execute and install Heron from an install script you can follow the
> steps below:
>
>
> $ chmod +x heron-install-0.20.5-incubating-{distro}.sh
> $ ./heron-install-0.20.5-incubating-{distro}.sh --user
>
> From here you should find disclaimers and other files in your ~/.heron
> directory.
> ls ~/.heron/
>
> DISCLAIMER    NOTICE        conf/         etc/          include/
> release.yaml
>
> LICENSE       bin/          dist/         examples/     lib/
>
>
> or refer to the compiling
> guidehttps://heron.incubator.apache.org/docs/next/compiling-overview/
> to setup the environment, build and run locally.
>
>  After Bazel is set up and works correctly, you can use these release check
> scripts as well.
> https://github.com/apache/incubator-heron/blob/master/scripts/release_check/README.md#run-individual-release-checks
> to verify the build.  The vote will be open for at least 72 hours or until
> the necessary number of votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
>
> The Apache Heron (Incubating) Team
>

Reply via email to