Thanks Maosong, So if was going to submit this as a PR (once it I have thoroughly tested it) I only need to document its config options in the example/metrics_sinks.yaml and not anywhere else (other than in the sinks java_doc)?
Tom Cooper W: www.tomcooper.org.uk | Twitter: @tomncooper <https://twitter.com/tomncooper> On 27 September 2017 at 11:17, Fu Maosong <[email protected]> wrote: > If it is only an example, you can just put it in the > example/metrics_sinks.yaml. > If you need to use it in actual env, then put it in the actual schedule > config folder. > > 2017-09-27 2:41 GMT-07:00 Thomas Cooper <[email protected]>: > > > Hi, > > > > I'm working on adding in support for sending metrics to InfluxDB. > > > > I was just wondering where the example config template for the sink > should > > live? > > > > There are multiple config folders under heron/config/src/yaml/conf (for > > each of the schedulers), should I just put my sink's config in the > > example/metrics_sinks.yaml or do I need to add a (commented out) example > in > > each scheduler's folder? > > > > Tom Cooper > > W: www.tomcooper.org.uk | Twitter: @tomncooper > > <https://twitter.com/tomncooper> > > > > > > -- > With my best Regards > ------------------ > Fu Maosong > Twitter Inc. > Mobile: +001-415-244-7520 >
