huijunwu commented on a change in pull request #2821: Update Dhalion dependency
version
URL: https://github.com/apache/incubator-heron/pull/2821#discussion_r178394376
##########
File path: heron/executor/src/python/heron_executor.py
##########
@@ -498,7 +498,7 @@ def _get_healthmgr_cmd(self):
"--cluster", self.cluster,
"--role", self.role,
"--environment", self.environment,
- "--topology_name", self.topology_name, "--verbose"]
+ "--topology_name", self.topology_name]
Review comment:
i would suggest either,
keep the -verbose now till the code is stable
or,
align the -verbose with 'heron submit xxx -verbose': If user supplies
verbose in cli, executor appends '-verbose'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
