nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a 
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378683450
 
 
   Yeah. It is a good point.
   
   I was changing the safe ones only in this PR to be quick. For the CHECK_EQ() 
<< "...." case I need to do some tests to verify the behavior of the library. 
Let me see if I can find some time to run the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to