Yaliang commented on a change in pull request #2842: Add json format for dry-run URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179238932
########## File path: heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java ########## @@ -0,0 +1,87 @@ +// Copyright 2018 Twitter. All rights reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package com.twitter.heron.scheduler.dryrun; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.node.ArrayNode; +import com.fasterxml.jackson.databind.node.ObjectNode; + +import com.twitter.heron.spi.packing.PackingPlan; +import com.twitter.heron.spi.packing.Resource; + +public class JsonFormatterUtils { + + private final ObjectMapper mapper; Review comment: ObjectMapper is usually used for a single dump call, while ObjectWriter is used for cases with intermediates steps. Re-using single ObjectMapper should be fine in this case based on my understanding. We have some internal and open source codes doing this kind of single object reusing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
