erenavsarogullari commented on a change in pull request #2864: S3Uploader 
improvements
URL: https://github.com/apache/incubator-heron/pull/2864#discussion_r180869982
 
 

 ##########
 File path: 
heron/uploaders/src/java/org/apache/heron/uploader/s3/S3Uploader.java
 ##########
 @@ -143,11 +143,14 @@ public void initialize(Config config) {
       builder.setClientConfiguration(clientCfg);
     }
 
-    s3Client = builder.withRegion(customRegion)
-            .withPathStyleAccessEnabled(true)
-            .withChunkedEncodingDisabled(true)
-            .withPayloadSigningEnabled(true)
-            .build();
+    if (customRegion != null && !customRegion.equals("")) {
 
 Review comment:
   @ajorgensen Thanks for the PR.
   What about `org.apache.commons.lang3.StringUtils.isNotBlank()` by supporting 
`not-null`, `not-empty`, also `not-whitespace` ("  ")?
   In addition to this, adding `UT Cases` can be useful for negative-cases 
(`customRegion = null / "" / "  "`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to