huijunw commented on a change in pull request #2886: [wip] submit topology file
by uri
URL: https://github.com/apache/incubator-heron/pull/2886#discussion_r186236468
##########
File path: heron/tools/cli/src/python/submit.py
##########
@@ -366,6 +368,16 @@ def submit_cpp(cl_args, unknown_args, tmp_dir):
return launch_topologies(cl_args, topology_file, tmp_dir)
+def download(uri):
+ current_path = os.path.realpath(__file__)
+ print current_path
+ tmp_dir = tempfile.mkdtemp()
+ subprocess.call([current_path + "downloader.sh", uri, tmp_dir])
+ suffix = (".jar", ".tar", ".tar.gz", ".pex", ".dylib", ".so")
+ for f in os.listdir(tmp_dir):
+ if f.endswith(suffix):
Review comment:
we need to make an agreement on this with users. the users may assume there
is only one file, or assume there are multiple files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
