srkukarni commented on a change in pull request #2891: Refactor StatefulStorage
API
URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187531976
##########
File path: heron/proto/ckptmgr.proto
##########
@@ -171,7 +175,26 @@ message CleanStatefulCheckpointResponse {
repeated string cleaned_checkpoint_ids = 2;
}
-// stmgr -> ckptmgr messages
+/*
+ * stmgr -> ckptmgr messages
+ */
+
+// This message encapsulates the info associated with
+// state of an instance/partition
+message InstanceStateCheckpoint {
+ required string checkpoint_id = 1;
+ required bytes state = 2;
+ // A version string that can be specified by user. It can be used to
translate
Review comment:
IMO this really pollutes the abstraction. You have now introduced some kind
of versioning in the system at such a low level to begin with without any kind
of higher level api/rationale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
