nwangtw commented on a change in pull request #2891: Refactor StatefulStorage
API
URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187630121
##########
File path: heron/proto/ckptmgr.proto
##########
@@ -195,6 +218,9 @@ message SaveInstanceStateRequest {
// Information about the instance whose state this is
required heron.proto.system.Instance instance = 1;
required InstanceStateCheckpoint checkpoint = 2;
+ // Stmgrs need to send component metadata so that Checkpoint
+ // Mgrs know how to repartition if needed.
+ optional CheckpointComponentMetadata metadata = 3;
Review comment:
But on the other hand, this could be a good idea. If ckptmgr receives the
topology structure during initialization, we can save the field from the
requests. Let me see how to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
