ajorgensen commented on issue #2900: Fix Potential Double Delete Bug URL: https://github.com/apache/incubator-heron/pull/2900#issuecomment-389895629 It's an improvement I think since there is a potential for a double free bug here if packets fail to send but I haven't seen a crash in production related to this yet. I think this change makes the pointer ownership semantics cleaner and easier to reason about.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
