On Thu, Apr 25, 2019 at 9:09 PM Ning Wang <[email protected]> wrote:
> Thanks. > > We fixed one memory leak issue in Jan and the fix is included in this RC. > Could you please create an issue for us to investigate? > > > On Thu, Apr 25, 2019 at 7:30 PM thinker0 <[email protected]> wrote: > >> -1 : The stream manager has a large memory leak. >> >> 2019년 4월 26일 (금) 오전 7:58, Ning Wang <[email protected]>님이 작성: >> >> > I believe I found the issue. Here is the PR: >> > https://github.com/apache/incubator-heron/pull/3245 >> > >> > On Wed, Apr 24, 2019 at 7:44 PM Ning Wang <[email protected]> wrote: >> > >> > > Yeah. It is sufficient to use the bazel command. I will use it in the >> > > future. Thanks for the suggestion. >> > > >> > > On Wed, Apr 24, 2019 at 5:19 PM Josh Fischer <[email protected]> >> > wrote: >> > > >> > >> Would it be sufficient for Julien to not use the >> > >> "build_release_packages.sh" script and just the bazel command to >> > generate >> > >> the heron-install.sh script and install and run from there? >> > >> >> > >> Something similar to "bazel build --config=darwin >> > >> scripts/packages:binpkgs"? >> > >> >> > >> On Wed, Apr 24, 2019 at 6:56 PM Ning Wang <[email protected]> >> wrote: >> > >> >> > >> > Tracking ticket created: >> > >> > https://github.com/apache/incubator-heron/issues/3243 >> > >> > >> > >> > On Wed, Apr 24, 2019 at 4:44 PM Ning Wang <[email protected]> >> > wrote: >> > >> > >> > >> > > I see. I think it is something I need to take a look at. >> > >> > > >> > >> > > The link is the official steps and it should work. >> > >> > > >> > >> > > The script is a convenient script and it is used by the CI job to >> > >> make a >> > >> > > build. >> > >> > > >> > >> > > >> > >> > > On Wed, Apr 24, 2019 at 4:41 PM Julien Le Dem >> > >> > > <[email protected]> wrote: >> > >> > > >> > >> > >> In your email you say: >> > >> > >> >> > >> > >> Please download the source package, and follow the compiling >> guide( >> > >> > >> >> > >> > >> >> > >> > >> > >> >> > >> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ >> > >> > >> Which I guess you mean only to setup your environment? >> > >> > >> And then use the script to build: "sh >> > >> > scripts/ci/build_release_packages.sh >> > >> > >> v0.20.1-incubating-rc2 darwin artifacts" >> > >> > >> >> > >> > >> On Wed, Apr 24, 2019 at 4:30 PM Julien Le Dem < >> > >> [email protected]> >> > >> > >> wrote: >> > >> > >> >> > >> > >> > following step 6: >> > >> > >> > >> > >> > >> > https://apache.github.io/incubator-heron/docs/developers/compiling/mac/ >> > >> > >> > >> > >> > >> > >> > >> > >> > On Wed, Apr 24, 2019 at 4:23 PM Ning Wang < >> [email protected]> >> > >> > wrote: >> > >> > >> > >> > >> > >> >> Thanks a lot! >> > >> > >> >> >> > >> > >> >> For the questions: >> > >> > >> >> 1. version of Bazel is on the website. We are fixing it >> > currently. >> > >> > >> >> 2. What is the command you use to build? This error is not >> > >> expected. >> > >> > I >> > >> > >> >> might missed it somewhere. >> > >> > >> >> >> > >> > >> >> >> > >> > >> >> >> > >> > >> >> >> > >> > >> >> On Wed, Apr 24, 2019 at 4:14 PM Julien Le Dem >> > >> > >> >> <[email protected]> wrote: >> > >> > >> >> >> > >> > >> >> > I did set >> > >> > >> >> > >> > >> > >> >> > HERON_BUILD_VERSION=v0.20.1-incubating and it works >> > >> > >> >> > >> > >> > >> >> > On Wed, Apr 24, 2019 at 4:12 PM Julien Le Dem < >> > >> > >> [email protected]> >> > >> > >> >> > wrote: >> > >> > >> >> > >> > >> > >> >> > > So the build works now. However I get this error: >> > >> > >> >> > > >> > >> > >> >> > > *ERROR: *Process exited with status 1: Process exited >> with >> > >> > status 1 >> > >> > >> >> > > >> > >> > >> >> > > scripts/release/status.sh: line 62: HERON_BUILD_VERSION: >> > >> unbound >> > >> > >> >> variable >> > >> > >> >> > > >> > >> > >> >> > > INFO: Elapsed time: 408.083s, Critical Path: 371.21s >> > >> > >> >> > > >> > >> > >> >> > > INFO: 1859 processes: 1525 local, 334 worker. >> > >> > >> >> > > >> > >> > >> >> > > *FAILED:* Build did NOT complete successfully >> > >> > >> >> > > >> > >> > >> >> > > >> > >> > >> >> > > You might want to have a BUILD file documenting those >> > >> > >> prerequisites in >> > >> > >> >> > the >> > >> > >> >> > > build tarball >> > >> > >> >> > > >> > >> > >> >> > > - how to get the correct version of bazel (current doc >> only >> > >> > shows >> > >> > >> >> how to >> > >> > >> >> > > get the latest) >> > >> > >> >> > > >> > >> > >> >> > > - what to put in the HERON_BUILD_VERSION var >> > >> > >> >> > > >> > >> > >> >> > > >> > >> > >> >> > > >> > >> > >> >> > > On Wed, Apr 24, 2019 at 3:17 PM Julien Le Dem < >> > >> > >> >> [email protected]> >> > >> > >> >> > > wrote: >> > >> > >> >> > > >> > >> > >> >> > >> nevermind: >> > >> > >> https://github.com/bazelbuild/bazel/releases?after=0.15.0 >> > >> > >> >> > >> It seems brew knows only about the latest version. >> > >> > >> >> > >> >> > >> > >> >> > >> On Wed, Apr 24, 2019 at 3:15 PM Julien Le Dem < >> > >> > >> >> [email protected]> >> > >> > >> >> > >> wrote: >> > >> > >> >> > >> >> > >> > >> >> > >>> how does one install bazel 0.14? >> > >> > >> >> > >>> >> > >> > >> >> > >>> On Wed, Apr 24, 2019 at 2:59 PM Ning Wang < >> > >> > [email protected]> >> > >> > >> >> > wrote: >> > >> > >> >> > >>> >> > >> > >> >> > >>>> Thanks Julien! >> > >> > >> >> > >>>> >> > >> > >> >> > >>>> Yeah. This RC was still with Bazel 0.14.1 since it was >> > >> created >> > >> > >> in >> > >> > >> >> > >>>> February. >> > >> > >> >> > >>>> Latest master works with Bazel 0.23.1. >> > >> > >> >> > >>>> >> > >> > >> >> > >>>> On Wed, Apr 24, 2019 at 2:47 PM Julien Le Dem >> > >> > >> >> > >>>> <[email protected]> wrote: >> > >> > >> >> > >>>> >> > >> > >> >> > >>>> > I was able to build from master but not from the >> > release >> > >> > >> tarbal. >> > >> > >> >> > >>>> > Is Bazel 0.14.1 actually required? Current release >> is >> > >> > 0.24.1. >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> > On Wed, Apr 24, 2019 at 2:25 PM Julien Le Dem < >> > >> > >> >> > >>>> [email protected]> >> > >> > >> >> > >>>> > wrote: >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> > > I'm looking into it. >> > >> > >> >> > >>>> > > I recently got a new laptop so doing the setup >> from >> > >> > scratch. >> > >> > >> >> > >>>> > > I had to follow: >> > >> > >> >> > >>>> > > >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://stackoverflow.com/questions/45276830/xcode-version-must-be-specified-to-use-an-apple-crosstool >> > >> > >> >> > >>>> > > I hit that error at step 6 here: >> > >> > >> >> > >>>> > > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> > >> >> https://apache.github.io/incubator-heron/docs/developers/compiling/mac/ >> > >> > >> >> > >>>> > > >> > >> > >> >> > >>>> > > On Sun, Apr 21, 2019 at 11:53 PM Ning Wang < >> > >> > >> >> [email protected]> >> > >> > >> >> > >>>> wrote: >> > >> > >> >> > >>>> > > >> > >> > >> >> > >>>> > >> On Fri, Apr 19, 2019 at 11:52 AM Ning Wang < >> > >> > >> >> [email protected] >> > >> > >> >> > > >> > >> > >> >> > >>>> > wrote: >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > Hi, dear Mentors, >> > >> > >> >> > >>>> > >> > >> > >> > >> >> > >>>> > >> > Please help if you have time. :) Thanks in >> > advance. >> > >> > >> >> > >>>> > >> > >> > >> > >> >> > >>>> > >> > --ning >> > >> > >> >> > >>>> > >> > >> > >> > >> >> > >>>> > >> > >> > >> > >> >> > >>>> > >> > On Fri, Apr 19, 2019 at 11:50 AM Ning Wang < >> > >> > >> >> > [email protected] >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> > >> wrote: >> > >> > >> >> > >>>> > >> > >> > >> > >> >> > >>>> > >> >> *Hello, Heron Community,* >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> *This is a call for a vote to the 2nd release >> > >> > candidate >> > >> > >> for >> > >> > >> >> > >>>> Apache >> > >> > >> >> > >>>> > >> Heron, >> > >> > >> >> > >>>> > >> >> version v0.20.1-incubating. This is a second >> pass >> > >> > since >> > >> > >> >> Dave >> > >> > >> >> > >>>> pointed >> > >> > >> >> > >>>> > >> out a >> > >> > >> >> > >>>> > >> >> few things that we weren’t clear before. The >> git >> > >> tag >> > >> > is >> > >> > >> the >> > >> > >> >> > >>>> same as >> > >> > >> >> > >>>> > the >> > >> > >> >> > >>>> > >> >> last time and the previous votes (four +1s >> from >> > >> > >> thinker0, >> > >> > >> >> > >>>> Karthik >> > >> > >> >> > >>>> > >> Ramasamy, >> > >> > >> >> > >>>> > >> >> Josh Fischer, Simong Weng) will be carried >> > over.The >> > >> > >> release >> > >> > >> >> > >>>> will be >> > >> > >> >> > >>>> > >> source >> > >> > >> >> > >>>> > >> >> only and I am going to remove the binary >> > packages. >> > >> We >> > >> > >> need >> > >> > >> >> to >> > >> > >> >> > >>>> reduce >> > >> > >> >> > >>>> > >> the >> > >> > >> >> > >>>> > >> >> size and another review before including them >> in >> > >> the >> > >> > >> >> > >>>> release.The tag >> > >> > >> >> > >>>> > >> to be >> > >> > >> >> > >>>> > >> >> voted upon:0.20.1-incubating-rc2 >> > >> > >> >> > >>>> > >> >> (e6134da336fa290fa1b40972bc747a7507948d8a)The >> > full >> > >> > list >> > >> > >> of >> > >> > >> >> > >>>> changes >> > >> > >> >> > >>>> > and >> > >> > >> >> > >>>> > >> >> release notes are available >> > >> > >> >> > >>>> > >> >> at: >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2 >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc2 >> > >> > >> >> > >>>> > >> >Release >> > >> > >> >> > >>>> > >> >> files can be found in dist.apache.org < >> > >> > >> >> http://dist.apache.org >> > >> > >> >> > > >> > >> > >> >> > >>>> > >> >> site: >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/ >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/ >> > >> > >> >> > >>>> > >> >Source: >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz >> > >> > >> >> > >>>> > >> >ASC >> > >> > >> >> > >>>> > >> >> signature: >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.asc >> > >> > >> >> > >>>> > >> >SHA512: >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512 >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-2/incubator-heron-0.20.1-incubating-rc2.tar.gz.sha512 >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> >c47fc8c228b5543f94dcf8fb5eb0f8083e84602be4f3b5ca52402b6e3e0f893434f971c317f44c3a69e78e597b96642fd69b5bec63e9a8eb7456c816f8e118f3 >> > >> > >> >> > >>>> > >> >> >> incubator-heron-0.20.1-incubating-rc2.tar.gzThe >> > >> > >> artifacts >> > >> > >> >> are >> > >> > >> >> > >>>> signed >> > >> > >> >> > >>>> > >> with >> > >> > >> >> > >>>> > >> >> PGP key 293DB72F865688D1, corresponding to >> > >> > >> >> [email protected] >> > >> > >> >> > >>>> > >> >> <[email protected]>, that can be found in keys >> > >> > >> >> > >>>> > >> >> file: >> > >> > >> >> > >>>> >> > >> > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> >> > >> > https://dist.apache.org/repos/dist/release/incubator/heron/KEYS >> > >> > >> >> > >>>> > >> >Please >> > >> > >> >> > >>>> > >> >> download the source package, and follow the >> > >> compiling >> > >> > >> >> > >>>> > >> >> guide( >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ >> > >> > >> >> > >>>> > >> >> < >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> >> > >> > >> > >> >> > >> https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ >> > >> > >> >> > >>>> > >> >)to >> > >> > >> >> > >>>> > >> >> build and run the Heron locally. Note that >> > >> currently >> > >> > >> Bazel >> > >> > >> >> > >>>> 0.14.1 is >> > >> > >> >> > >>>> > >> >> required to build this version.For your >> > >> convenience, >> > >> > >> here >> > >> > >> >> are >> > >> > >> >> > a >> > >> > >> >> > >>>> few >> > >> > >> >> > >>>> > >> >> commands I used:License check:$ java -jar >> > >> > >> >> > >>>> > >> ~/Downloads/apache-rat-0.12.jar . >> > >> > >> >> > >>>> > >> >> -E .rat-excludesBuild the binary package for >> Mac >> > >> OS:$ >> > >> > sh >> > >> > >> >> > >>>> > >> >> scripts/ci/build_release_packages.sh >> > >> > >> v0.20.1-incubating-rc2 >> > >> > >> >> > >>>> darwin >> > >> > >> >> > >>>> > >> >> artifactsBuild the docker image for Debian 9$ >> > bash >> > >> > >> >> > >>>> > >> >> scripts/ci/build_docker_image.sh >> > >> > v0.20.1-incubating-rc2 >> > >> > >> >> > debian9 >> > >> > >> >> > >>>> > >> >> artifactsThe vote will be open for at least 72 >> > >> hours >> > >> > or >> > >> > >> >> until >> > >> > >> >> > >>>> the >> > >> > >> >> > >>>> > >> necessary >> > >> > >> >> > >>>> > >> >> number of votes are reached. Hopefully we can >> get >> > >> > enough >> > >> > >> >> > (three) >> > >> > >> >> > >>>> > votes >> > >> > >> >> > >>>> > >> from >> > >> > >> >> > >>>> > >> >> mentors.Please vote accordingly:[ ] +1 >> approve[ ] >> > >> +0 >> > >> > no >> > >> > >> >> > >>>> opinion[ ] -1 >> > >> > >> >> > >>>> > >> >> disapprove with the reasonThanks,The Apache >> Heron >> > >> > >> >> (Incubating) >> > >> > >> >> > >>>> Team* >> > >> > >> >> > >>>> > >> >> >> > >> > >> >> > >>>> > >> > >> > >> > >> >> > >>>> > >> >> > >> > >> >> > >>>> > > >> > >> > >> >> > >>>> > >> > >> > >> >> > >>>> >> > >> > >> >> > >>> >> > >> > >> >> > >> > >> > >> >> >> > >> > >> > >> > >> > >> >> > >> > > >> > >> > >> > >> >> > > >> > >> >
