Nice. AbstractCollect refactoring is necessary, can make the new monitoring type adaptation more standardized and easier to understand. HIP vote i will +1.
Best Wishes, Tom On 2024/05/07 16:07:17 Jie crossover wrote: > Hi HertzBeat Community, > > When I was writing unit tests, I noticed that there was a preCheck > validation logic in each collector. Therefore, I suggest implementing this > method separately to make the code structure clearer and more conducive to > unit testing. > > Please see the HIP: https://github.com/apache/hertzbeat/pull/1930 > -- > Best Regards！ > crossoverJie > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hertzbeat.apache.org For additional commands, e-mail: dev-h...@hertzbeat.apache.org
