[ 
https://issues.apache.org/jira/browse/HIVE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922284#action_12922284
 ] 

Namit Jain commented on HIVE-1638:
----------------------------------

    } else if 
(TypeInfoUtils.getTypeInfoFromObjectInspector(arguments[0]).equals(
        TypeInfoFactory.byteTypeInfo) &&
        TypeInfoUtils.getTypeInfoFromObjectInspector(arguments[1]).equals(
          TypeInfoFactory.byteTypeInfo)) {
        compareType = CompareType.COMPARE_LONG;
        byoi0 = (ByteObjectInspector) arguments[0];
        byoi1 = (ByteObjectInspector) arguments[1];
    }


It should be COMPARE_BYTE instead

> convert commonly used udfs to generic udfs
> ------------------------------------------
>
>                 Key: HIVE-1638
>                 URL: https://issues.apache.org/jira/browse/HIVE-1638
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Siying Dong
>         Attachments: HIVE-1638.1.patch, HIVE-1638.2.patch, HIVE-1638.3.patch, 
> HIVE-1638.4.patch
>
>
> Copying a mail from Joy:
> i did a little bit of profiling of a simple hive group by query today. i was 
> surprised to see that one of the most expensive functions were in converting 
> the equals udf (i had some simple string filters) to generic udfs. 
> (primitiveobjectinspectorconverter.textconverter)
> am i correct in thinking that the fix is to simply port some of the most 
> popular udfs (string equality/comparison etc.) to generic udsf?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to