[ 
https://issues.apache.org/jira/browse/HIVE-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932175#action_12932175
 ] 

John Sichi commented on HIVE-1785:
----------------------------------

As mentioned above, we don't want to make a breaking change to the hook 
interface.  To do this, create a new interface PreExecuteWithContext and add 
the new method there.  Then, when invoking hooks, use instanceof to detect 
whether the class implements PreExecuteWithContext.  If not, invoke using the 
old interface+method.

Repeat for PostExecute.


> change Pre/Post Query Hooks to take in 1 parameter: HookContext
> ---------------------------------------------------------------
>
>                 Key: HIVE-1785
>                 URL: https://issues.apache.org/jira/browse/HIVE-1785
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Liyin Tang
>         Attachments: hive_1785_1.patch
>
>
> This way, it would be possible to add new parameters to the hooks without 
> changing the existing hooks.
> This will be a incompatible change, and all the hooks need to change to the 
> new API

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to