[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934640#action_12934640 ]
HBase Review Board commented on HIVE-1526: ------------------------------------------ Message from: "Ning Zhang" <n.nin...@gmail.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1242/#review1958 ----------------------------------------------------------- .classpath._hbase <http://review.cloudera.org/r/1242/#comment6177> Is deleting of this file because of we eliminated hadoop pre-0.20 versions? John, can you confirm if this file can be deleted? ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java <http://review.cloudera.org/r/1242/#comment6207> This should not be MAPREDLOCAL, but MAPRED. Since MapRedTask extends ExecDriver which implements getType(), this function should not be here in MapRedTask. ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java <http://review.cloudera.org/r/1242/#comment6208> It would be better to define a new OperatorType for SMBMapJoinOperator. ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java <http://review.cloudera.org/r/1242/#comment6209> commnet: -1 -> null - Ning > Hive should depend on a release version of Thrift > ------------------------------------------------- > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hive > Issue Type: Task > Components: Build Infrastructure, Clients > Reporter: Carl Steinbach > Assignee: Carl Steinbach > Fix For: 0.7.0 > > Attachments: HIVE-1526-no-codegen.3.patch.txt, HIVE-1526.2.patch.txt, > HIVE-1526.3.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar, > serde2_test.patch, svn_rm.sh, thrift-0.5.0.jar, thrift-fb303-0.5.0.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.