-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1242/
-----------------------------------------------------------
(Updated 2010-11-29 02:30:23.538215)
Review request for Hive Developers.
Changes
-------
Patch updated with changes suggested by Ning and Ashutosh.
Summary
-------
Review request for HIVE-1526: upgrade to Thrift 0.5.0
This review request does not include the code generated by the Thrift compiler.
This addresses bug HIVE-1526.
http://issues.apache.org/jira/browse/HIVE-1526
Diffs (updated)
-----
.classpath._hbase 15fd1c5
.gitignore e54804f
build-common.xml 53fd1b1
build.xml dc20725
eclipse-templates/.classpath d06d6bd
eclipse-templates/.classpath._hbase b81c24a
ivy/libraries.properties fdd54c8
lib/README 72d90b7
lib/libfb303.LICENSE 6b5c3b1
lib/libfb303.jar 516b597
lib/libthrift.LICENSE 6b5c3b1
lib/libthrift.jar 7e7f90e
lib/thrift-0.5.0.jar PRE-CREATION
lib/thrift-fb303-0.5.0.jar PRE-CREATION
lib/thrift-fb303.LICENSE PRE-CREATION
lib/thrift.LICENSE PRE-CREATION
metastore/build.xml ffb86c1
metastore/if/hive_metastore.thrift 0e47312
metastore/ivy.xml 2e39eb8
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
96ef5b7
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4c977b8
odbc/Makefile 816ffd4
odbc/build.xml 64cf988
odbc/src/cpp/HiveRowSet.cpp b4dc2c0
odbc/src/cpp/hiveclienthelper.cpp e2d48f3
ql/build.xml a025a2b
ql/if/queryplan.thrift aca0e8f
ql/ivy.xml e72a450
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
5ccb909
ql/src/java/org/apache/hadoop/hive/ql/exec/CollectOperator.java 7daea2d
ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java bf7b7a5
ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 46b8bf4
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 7168884
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 49e708c
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java a572bcb
ql/src/java/org/apache/hadoop/hive/ql/exec/ExtractOperator.java 7bf8886
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java de2c42d
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java d510f95
ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 554bf25
ql/src/java/org/apache/hadoop/hive/ql/exec/ForwardOperator.java 2a35c96
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1e6941e
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 8423178
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java
87fc61c
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 4cf055f
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java e16df36
ql/src/java/org/apache/hadoop/hive/ql/exec/LateralViewForwardOperator.java
c070aca
ql/src/java/org/apache/hadoop/hive/ql/exec/LateralViewJoinOperator.java
5eb9098
ql/src/java/org/apache/hadoop/hive/ql/exec/LimitOperator.java da5dbb9
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java c9f99ac
ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 887ad30
ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 0fab63c
ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java c5aa3d6
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7fbc586
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 6c6ea89
ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 592f4f7
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 001d1f0
ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4f8b4bd
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java d644a33
ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 47adbed
ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 96e63b8
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 893530c
ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java 682f38a
ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 2c42ed7
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
0d60507
ql/src/java/org/apache/hadoop/hive/ql/index/compact/IndexMetadataChangeTask.java
734bd72
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 5d33550
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 7167196
serde/build.xml b64b142
serde/ivy.xml da69342
serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java
961c24f
serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java
e781a06
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorUtils.java
4bdcf88
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java
99b0e90
service/build.xml ffd1854
service/if/hive_service.thrift db9fab6
service/include/thrift/TLogging.h 2df82dd
service/include/thrift/TProcessor.h f2d5279
service/include/thrift/TReflectionLocal.h e83e475
service/include/thrift/Thrift.h 27a6476
service/include/thrift/concurrency/Exception.h ec46629
service/include/thrift/concurrency/FunctionRunner.h 2216927
service/include/thrift/concurrency/Monitor.h 234bf32
service/include/thrift/concurrency/Mutex.h 73c73e0
service/include/thrift/concurrency/PosixThreadFactory.h d6d83a3
service/include/thrift/concurrency/Thread.h d4282ad
service/include/thrift/concurrency/ThreadManager.h 6e5a178
service/include/thrift/concurrency/TimerManager.h dfbf0ea
service/include/thrift/concurrency/Util.h 25fcc20
service/include/thrift/config.h 70264f2
service/include/thrift/fb303/FacebookBase.h fd169e6
service/include/thrift/fb303/FacebookService.h dcd843f
service/include/thrift/fb303/FacebookService.cpp 4a34362
service/include/thrift/fb303/ServiceTracker.h 9304386
service/include/thrift/fb303/fb303_constants.h 19405bc
service/include/thrift/fb303/fb303_constants.cpp 66b8782
service/include/thrift/fb303/fb303_types.h 18936f9
service/include/thrift/fb303/fb303_types.cpp f290125
service/include/thrift/fb303/if/fb303.thrift 66c8315
service/include/thrift/if/reflection_limited.thrift 993c46e
service/include/thrift/processor/PeekProcessor.h 0f7c016
service/include/thrift/processor/StatsProcessor.h 820b3ad
service/include/thrift/protocol/TBase64Utils.h 3def733
service/include/thrift/protocol/TBinaryProtocol.h 7fd3de6
service/include/thrift/protocol/TCompactProtocol.h b4e06f0
service/include/thrift/protocol/TDebugProtocol.h ab69e0c
service/include/thrift/protocol/TDenseProtocol.h 7655a47
service/include/thrift/protocol/TJSONProtocol.h 2df499a
service/include/thrift/protocol/TOneWayProtocol.h 6f08fe1
service/include/thrift/protocol/TProtocol.h 4025827
service/include/thrift/protocol/TProtocolException.h 33011b3
service/include/thrift/protocol/TProtocolTap.h 5580216
service/include/thrift/reflection_limited_types.h 677cb4a
service/include/thrift/server/TNonblockingServer.h 8506507
service/include/thrift/server/TServer.h 5c4c588
service/include/thrift/server/TSimpleServer.h c4fc91c
service/include/thrift/server/TThreadPoolServer.h 7b7e906
service/include/thrift/server/TThreadedServer.h 4d0811a
service/include/thrift/transport/TBufferTransports.h 1908205
service/include/thrift/transport/TFDTransport.h bda5d82
service/include/thrift/transport/TFileTransport.h b08c5c8
service/include/thrift/transport/THttpClient.h f4be4c1
service/include/thrift/transport/TServerSocket.h a6be017
service/include/thrift/transport/TServerTransport.h 40bbc6c
service/include/thrift/transport/TShortReadTransport.h 3df8a57
service/include/thrift/transport/TSimpleFileTransport.h 6cc52ea
service/include/thrift/transport/TSocket.h b0f445a
service/include/thrift/transport/TSocketPool.h 8c50669
service/include/thrift/transport/TTransport.h eb0d5df
service/include/thrift/transport/TTransportException.h 330785c
service/include/thrift/transport/TTransportUtils.h d65c916
service/include/thrift/transport/TZlibTransport.h 1439d9d
service/src/java/org/apache/hadoop/hive/service/HiveServer.java 89cf336
Diff: http://review.cloudera.org/r/1242/diff
Testing
-------
Thanks,
Carl
