[
https://issues.apache.org/jira/browse/HIVE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971442#action_12971442
]
John Sichi commented on HIVE-78:
--------------------------------
We can't take the size of a patch as a justification for checking in code which
doesn't pass review, especially for things like JDO and Thrift API's which are
going to be there forever. I discussed it with Namit and his suggestion was to
break it down into smaller patches to be committed in sequence so that we can
divide-and-conquer the review process. For future projects, it would be great
if we can do the same for the design process itself so that the coding doesn't
get too far ahead of the design (which is how we end up with giant patches).
The items below are OK for followups
2. revokeAllPrivileges should revoke role grants as well
3. Role cycle is not being prevented
6. GRANT should mark WriteEntity for replication etc
For this one, we should at least work out the metastore model as part of the
JDO changes:
7. Provide a way to make partitions inherit from table (and make it the default)
The rest need to be addressed up front as part of the relevant patches.
Separately, maybe using git for branch+merge would help make development of a
feature of this size more manageable? (If you're not already.)
> Authorization infrastructure for Hive
> -------------------------------------
>
> Key: HIVE-78
> URL: https://issues.apache.org/jira/browse/HIVE-78
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Query Processor, Server Infrastructure
> Reporter: Ashish Thusoo
> Assignee: He Yongqiang
> Attachments: createuser-v1.patch, hive-78-metadata-v1.patch,
> hive-78-syntax-v1.patch, HIVE-78.1.nothrift.patch, HIVE-78.1.thrift.patch,
> HIVE-78.2.nothrift.patch, HIVE-78.2.thrift.patch, HIVE-78.4.complete.patch,
> HIVE-78.4.no_thrift.patch, HIVE-78.5.complete.patch,
> HIVE-78.5.no_thrift.patch, HIVE-78.6.complete.patch,
> HIVE-78.6.no_thrift.patch, HIVE-78.7.no_thrift.patch, HIVE-78.7.patch,
> hive-78.diff
>
>
> Allow hive to integrate with existing user repositories for authentication
> and authorization infromation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
