[ 
https://issues.apache.org/jira/browse/HIVE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975689#action_12975689
 ] 

Namit Jain commented on HIVE-78:
--------------------------------

hive-default.xml:

<property>
  <name>hive.variable.substitute</name>
  <value>true</value>
  <description>This enables substitution using syntax like ${var} ${system:var} 
and ${env:var}.</description>
</property>

seems like a merge problem.




package.jdo:

no index needed on ROLE_ID


ALTER TABLE authorization_part SET TBLPROPERTIES 
("PARTITION_LEVEL_PRIVILEGE"="TRUE");


Dont load partition specific priviliges for tables that do no have a separate 
partition level priv.

ObjectStore.java: add comments for getGrantObjects

HiveMetaStoreClient.java: no need for setEmpotyGrantList()
you should always create a empty list for a user,role or group.



DefaultHiveAuthorizationProvider.java:

Can you add comments for all the (private) functions ?
It is not obvious what is the meaning of the return value ?



Still reviewing.

> Authorization infrastructure for Hive
> -------------------------------------
>
>                 Key: HIVE-78
>                 URL: https://issues.apache.org/jira/browse/HIVE-78
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore, Query Processor, Server Infrastructure
>            Reporter: Ashish Thusoo
>            Assignee: He Yongqiang
>         Attachments: createuser-v1.patch, hive-78-metadata-v1.patch, 
> hive-78-syntax-v1.patch, HIVE-78.1.nothrift.patch, HIVE-78.1.thrift.patch, 
> HIVE-78.10.no_thrift.patch, HIVE-78.2.nothrift.patch, HIVE-78.2.thrift.patch, 
> HIVE-78.4.complete.patch, HIVE-78.4.no_thrift.patch, 
> HIVE-78.5.complete.patch, HIVE-78.5.no_thrift.patch, 
> HIVE-78.6.complete.patch, HIVE-78.6.no_thrift.patch, 
> HIVE-78.7.no_thrift.patch, HIVE-78.7.patch, HIVE-78.9.no_thrift.patch, 
> HIVE-78.9.patch, hive-78.diff
>
>
> Allow hive to integrate with existing user repositories for authentication 
> and authorization infromation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to