[ 
https://issues.apache.org/jira/browse/HIVE-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siying Dong updated HIVE-1517:
------------------------------

    Attachment: HIVE-1517.3.patch

Modify based on Carl's previous patch:
1. fix concurrency issue but locking DB for every table too
2. fix CREATE TABLE AS and CREATE TABLE LIKE. Also, CREATE TABLE AS to share 
the same codes to generate default path as CREATE TABLE
3. fix TABLESAMPLE, DROP TABLE, DROP TABLE, ALTER TABLE DROP PARTITION, etc.
4. fix the same table names in different databases in the same query. 
(PartitionPruner's key's problem)
5. fix character escaping problem.
6. fix TABLE ANALYZE to mistakely allow xxx.xxx
7. fix DynamicSerDe just to get unit test pass.
8. lots of test case results changes, since in DESCRIBE EXTENDED, table names 
are printed to be default.tab instead of tab. I found the possible way not to 
print "default" to make less change to test outputs is more risky. So I didn't 
try that. But I ever implemented it on my machine and make sure those test 
output modifications are right.

Some issues:
1. I didn't figure out the necessity to modify SemanticAnalyzer.processTable() 
not to use aliasIndex in Carl's patch, so I revert them.
2. DESCRIBE a foreign table is not supported and we don't give good error 
message.
3. `db.tab` is not blocked so far since I found it's a pretty complicated issue 
and might need more thinking.
4. UnparseTranslator becomes a little bit urgly now to unescape identifiers. I 
found it's really hard to keep Carl's syntax rules and still support it in a 
clean way. Maybe as a follow-up to make DB and table two different tokens, 
instead of parsing 'xxx.xxx' to semantic analyzer.

I'm still running test suites from the beginning to the end. There still can be 
something broken.

> ability to select across a database
> -----------------------------------
>
>                 Key: HIVE-1517
>                 URL: https://issues.apache.org/jira/browse/HIVE-1517
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Siying Dong
>            Priority: Blocker
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1517.1.patch.txt, HIVE-1517.2.patch.txt, 
> HIVE-1517.3.patch
>
>
> After  https://issues.apache.org/jira/browse/HIVE-675, we need a way to be 
> able to select across a database for this feature to be useful.
> For eg:
> use db1
> create table foo(....);
> use db2
> select .. from db1.foo.....

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to