[
https://issues.apache.org/jira/browse/HIVE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993189#comment-12993189
]
He Yongqiang commented on HIVE-818:
-----------------------------------
The change looks good to me.
a few minor comments:
1) do you need to increase the VERSION number in HiveServer?
2) is it better to put the setupSessionIO() in execute()? If it is already
there, should we remove the one in the constructor? And cleanup the Driver at
the end of execute()?
3) the len and pos local var in cleanTmpFile is not used.
4) maybe not related to this jira: the SessionState in Hive is thread local
object, is it guaranteed that the HiveServerHandler is also thread local, (so
there is a 1-1 match)?
> Create a Hive CLI that connects to hive ThriftServer
> ----------------------------------------------------
>
> Key: HIVE-818
> URL: https://issues.apache.org/jira/browse/HIVE-818
> Project: Hive
> Issue Type: New Feature
> Components: Clients, Server Infrastructure
> Reporter: Edward Capriolo
> Assignee: Ning Zhang
> Attachments: HIVE-818.2.patch, HIVE-818.patch, Hive-881_2.patch
>
>
> We should have an alternate CLI that works by interacting with the
> HiveServer, in this way it will be ready when/if we deprecate the current CLI.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
