----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/448/#review270 -----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldList.java <https://reviews.apache.org/r/448/#comment516> Earlier for-each loop was being used to fill a list with default values. Now a normal loop is being used to fill the list with default values. In both the approaches, either the temp variable or the loop variable remain unused. Because of which @Suppress... has to be used. i would suggest, we can rather use java.util.Collections.fill(List<? super T> list, T obj) API, to fill a list with default values. - M On 2011-02-28 17:05:03, Jon Stevens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/448/ > ----------------------------------------------------------- > > (Updated 2011-02-28 17:05:03) > > > Review request for hive. > > > Summary > ------- > > fix some eclipse warnings. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java > 52d14ae > ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java ff74f08 > ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java > 157606f > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 096267c > ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java b02ddd3 > serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 4047bda > > serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java > c6a7f34 > serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarStruct.java > b062460 > > serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldList.java > 1ce53ef > > serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeTypeList.java > 35b258d > > serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeTypeMap.java > 2b5d63c > > serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeTypeSet.java > b78439e > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardListObjectInspector.java > 69edd65 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardMapObjectInspector.java > 095c343 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java > 3b26e45 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java > 3eea7e9 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java > 49d9c1d > > serde/src/test/org/apache/hadoop/hive/serde2/dynamic_type/TestDynamicSerDe.java > f8d1142 > service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java e92ece1 > shims/src/0.20/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java b28bf4e > shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 6fdb6f8 > shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java bcf230f > shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java 27a3540 > > Diff: https://reviews.apache.org/r/448/diff > > > Testing > ------- > > none... > > > Thanks, > > Jon > >
