----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/491/#review324 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment653> ConcurrentHashMap would have been a better choice, as it will not require additional synchronization to be done from the user. But the current implementation does. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment654> Instead of choosing not to create a ThreadPool we could have instead opted to create a single threaded pool. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment652> Redeclaration could have been avoided by declaring the variables just once outside the loop and initializing them inside the loop, in which case we need not make them as final. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment655> Here we need to consider the Future object that we obtain when we submit the job. And use the same to ensure that task gets over. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment656> Even before ensuring that submitted tasks have been completed, it'll be little dangerous to shutdown the thread-pool, as the other tasks that have been submitted but not yet started may not run at all. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment651> Please use the entry set to iterate over the map elements. - M On 2011-03-11 15:03:34, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/491/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:03:34) > > > Review request for hive. > > > Summary > ------- > > Review request for HIVE-2051. > > > This addresses bug HIVE-2051. > https://issues.apache.org/jira/browse/HIVE-2051 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1080771 > > Diff: https://reviews.apache.org/r/491/diff > > > Testing > ------- > > > Thanks, > > Carl > >
