----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review333 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java <https://reviews.apache.org/r/489/#comment674> will do. trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java <https://reviews.apache.org/r/489/#comment673> I think explicitly catching HiveException and throw it away will save the creation of HiveException in the catch(Exception) block, right? trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java <https://reviews.apache.org/r/489/#comment675> I agree in general we should use a generic interface in the declaration, but I'd prefer leave the LinkedHashMap here. The reason is that what we need for the partSpec is an ordered map where the order of iterator.getNext() should be the same order of elements being inserted. Unfortunately Java collections doesn't have this interface but just an implementation. We could declare an interface just for that, but that should be a different issue. - Ning On 2011-03-11 14:59:46, Ning Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/489/ > ----------------------------------------------------------- > > (Updated 2011-03-11 14:59:46) > > > Review request for hive. > > > Summary > ------- > > * expose HiveMetaStoreClient.listPartitionsByFilter() to Hive.java so > that PartitionPruner can use that for certain partition predicates. > * only allows {=, AND, OR} in the partition predicates that can be pushed > down to JDO filtering. > > > Diffs > ----- > > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 1080788 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1080788 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1080788 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1080788 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 1080788 > > Diff: https://reviews.apache.org/r/489/diff > > > Testing > ------- > > > Thanks, > > Ning > >
