----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/514/#review335 -----------------------------------------------------------
trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java <https://reviews.apache.org/r/514/#comment677> This could be quite expensive if fetchedRows is an ArrayList. Could you initial an iterator after fetchRows=client.fetchN() and just use the iterator.next() here? - Ning On 2011-03-16 01:17:22, Bennie Schut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/514/ > ----------------------------------------------------------- > > (Updated 2011-03-16 01:17:22) > > > Review request for hive. > > > Summary > ------- > > HIVE-1815: The class HiveResultSet should implement batch fetching. > > > This addresses bug HIVE-1815. > https://issues.apache.org/jira/browse/HIVE-1815 > > > Diffs > ----- > > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java > 1081785 > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java 1081785 > trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 1081785 > > Diff: https://reviews.apache.org/r/514/diff > > > Testing > ------- > > > Thanks, > > Bennie > >