[ https://issues.apache.org/jira/browse/HIVE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014005#comment-13014005 ]
jirapos...@reviews.apache.org commented on HIVE-2080: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/535/ ----------------------------------------------------------- Review request for hive. Summary ------- Few code improvements in the ql and serde packages. 1) Little performance Improvements 2) Null checks to avoid NPEs 3) Effective varaible management. This addresses bug HIVE-2080. https://issues.apache.org/jira/browse/HIVE-2080 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1086514 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1086514 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeField.java 1086514 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldType.java 1086514 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFunction.java 1086514 Diff: https://reviews.apache.org/r/535/diff Testing ------- Ran the tests. All tests passed Thanks, chinna > Few code improvements in the ql and serde packages. > --------------------------------------------------- > > Key: HIVE-2080 > URL: https://issues.apache.org/jira/browse/HIVE-2080 > Project: Hive > Issue Type: Bug > Components: Query Processor, Serializers/Deserializers > Affects Versions: 0.7.0 > Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise > Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5). > Reporter: Chinna Rao Lalam > Assignee: Chinna Rao Lalam > Attachments: HIVE-2080.Patch > > > Few code improvements in the ql and serde packages. > 1) Little performance Improvements > 2) Null checks to avoid NPEs > 3) Effective varaible management. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira