[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023098#comment-13023098
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/558/#review528
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
<https://reviews.apache.org/r/558/#comment1094>
When we run a query on a non-partitioned table, we get a single partition
in queryPartitions of the whole table (with an empty partSpec). Then, when we
add the partition columns to the list of indexed column, we end up adding all
the columns in the src table, instead of just the partitioned ones. If we make
sure the partSpec isn't empty, this doesn't happen.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
<https://reviews.apache.org/r/558/#comment1095>
We need to cast the work in this task to MapredWork in order to get the
input size out (line 176). I'm not sure if this is the best place to do that
checking.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
<https://reviews.apache.org/r/558/#comment1096>
See above comment about MapredWork
- Russell
On 2011-04-22 03:50:54, Russell Melick wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/558/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-22 03:50:54)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review request for HIVE-1644.12.patch
bq.
bq.
bq. This addresses bug HIVE-1644.
bq. https://issues.apache.org/jira/browse/HIVE-1644
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2cdaeb6
bq. conf/hive-default.xml 79ea477
bq. ql/src/java/org/apache/hadoop/hive/ql/Driver.java ca337a8
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 69ee03b
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java
c02d90b
bq. ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java
dd0186d
bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexHandler.java
411b78f
bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java
PRE-CREATION
bq.
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
1f01446
bq. ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 50db44c
bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java
6162676
bq.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/IndexWhereResolver.java
PRE-CREATION
bq.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java
0ae9fa2
bq.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java
PRE-CREATION
bq.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
PRE-CREATION
bq.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java
PRE-CREATION
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 374e123
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
c41bb32
bq. ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 73391e9
bq. ql/src/test/queries/clientpositive/index_auto.q PRE-CREATION
bq. ql/src/test/queries/clientpositive/index_auto_file_format.q PRE-CREATION
bq. ql/src/test/queries/clientpositive/index_auto_multiple.q PRE-CREATION
bq. ql/src/test/queries/clientpositive/index_auto_partitioned.q PRE-CREATION
bq. ql/src/test/queries/clientpositive/index_auto_unused.q PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto.q.out PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto_file_format.q.out
PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto_multiple.q.out
PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto_partitioned.q.out
PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto_unused.q.out PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/558/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Russell
bq.
bq.
> use filter pushdown for automatically accessing indexes
> -------------------------------------------------------
>
> Key: HIVE-1644
> URL: https://issues.apache.org/jira/browse/HIVE-1644
> Project: Hive
> Issue Type: Improvement
> Components: Indexing
> Affects Versions: 0.8.0
> Reporter: John Sichi
> Assignee: Russell Melick
> Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch,
> HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch,
> HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.2.patch, HIVE-1644.3.patch,
> HIVE-1644.4.patch, HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch,
> HIVE-1644.8.patch, HIVE-1644.9.patch
>
>
> HIVE-1226 provides utilities for analyzing filters which have been pushed
> down to a table scan. The next step is to use these for selecting available
> indexes and generating access plans for those indexes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
