----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/626/#review609 -----------------------------------------------------------
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java <https://reviews.apache.org/r/626/#comment1252> This change kills the launched MR job. however the following interrupt() only called to the current thread. This does not really behaves what it is expected to be when there are multiple threads running. For example when we are getting partitions from metastore (JDO may use its thread pool) and when getting HDFS summaries (we are also using thread pool). For these situations we probably need to interrupt all child threads. - Ning On 2011-04-28 20:54:48, georgedj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/626/ > ----------------------------------------------------------- > > (Updated 2011-04-28 20:54:48) > > > Review request for hive. > > > Summary > ------- > > Fixed by adding INT signal hander that interrupts the CLI thread. The CLI > thread gets InterruptedException and it stops the current command. > > > This addresses bug HIVE-243. > https://issues.apache.org/jira/browse/HIVE-243 > > > Diffs > ----- > > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1097569 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java > 1097569 > > Diff: https://reviews.apache.org/r/626/diff > > > Testing > ------- > > Manual test Ctrl+C on bunch of command (show tables, select, etc) > > > Thanks, > > georgedj > >
