[
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026743#comment-13026743
]
jirapos...@reviews.apache.org commented on HIVE-243:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review609
-----------------------------------------------------------
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/626/#comment1252>
This change kills the launched MR job. however the following interrupt()
only called to the current thread. This does not really behaves what it is
expected to be when there are multiple threads running.
For example when we are getting partitions from metastore (JDO may use its
thread pool) and when getting HDFS summaries (we are also using thread pool).
For these situations we probably need to interrupt all child threads.
- Ning
On 2011-04-28 20:54:48, georgedj wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/626/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-28 20:54:48)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixed by adding INT signal hander that interrupts the CLI thread. The CLI
thread gets InterruptedException and it stops the current command.
bq.
bq.
bq. This addresses bug HIVE-243.
bq. https://issues.apache.org/jira/browse/HIVE-243
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1097569
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
1097569
bq.
bq. Diff: https://reviews.apache.org/r/626/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.
bq.
bq. Thanks,
bq.
bq. georgedj
bq.
bq.
> ^C breaks out of running query, but not whole CLI
> -------------------------------------------------
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
> Issue Type: Wish
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it.
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was
> some control character to break out of a query without breaking out of the
> CLI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
