[ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Syed S. Albiz updated HIVE-2155:
--------------------------------

    Attachment: HIVE-2155.3.patch

Instead of changing the overall structure, I decided to move the logic to print 
that context token into the new generateErrorMessage method, which prevents 
breaking existing error messages which rely on that behavior of an error token 
finishing the message.

> Improve error messages emitted during semantic analysis
> -------------------------------------------------------
>
>                 Key: HIVE-2155
>                 URL: https://issues.apache.org/jira/browse/HIVE-2155
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Syed S. Albiz
>            Assignee: Syed S. Albiz
>         Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch
>
>
> Follow-up to HIVE-1731.
> A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
> reporting errors correctly.
> Specifically, the following issues need to be addressed:
> - Line numbers are not always provided and sometimes emitted as (0:-1), which 
> is useless
> - Insufficient or unclear context strings are provided
> Specific issues described in HIVE-1731:
> FAILED: Error in semantic analysis: Schema of both sides of union should 
> match: destinationid:_col1 _col2
> * No line/col numbers, context strings provide internal aliases instead of 
> actual column names
> FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
> Encountered in Join time
> * Incorrect line/col number info, no context strings to describe the aliases 
> encountered
> FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
> * No line/col numbers, not context string to show the aliases encountered
> FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
> * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
> * Context string is unhelpful, needs to provide the actual expression, not 
> just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to