> On 2011-06-13 21:47:25, John Sichi wrote: > > trunk/metastore/src/model/package.jdo, line 670 > > <https://reviews.apache.org/r/883/diff/1/?file=20978#file20978line670> > > > > Does indexing actually work on a LONGVARCHAR field across all DB's of > > interest?
No, it doesn't. So, I reverted it back to VARCHAR. If the rest of the patch looks alright, I will attach a new patch with this change. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/#review822 ----------------------------------------------------------- On 2011-06-10 21:24:13, Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/883/ > ----------------------------------------------------------- > > (Updated 2011-06-10 21:24:13) > > > Review request for hive and John Sichi. > > > Summary > ------- > > Follow-up for HIVE-2147. > > > This addresses bug HIVE-2215. > https://issues.apache.org/jira/browse/HIVE-2215 > > > Diffs > ----- > > trunk/metastore/if/hive_metastore.thrift 1134443 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1134443 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1134443 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 1134443 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java > 1134443 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1134443 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java > 1134443 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MarkPartitionEvent.java > PRE-CREATION > > trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java > PRE-CREATION > trunk/metastore/src/model/package.jdo 1134443 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java > 1134443 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionSet.java > PRE-CREATION > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > 1134443 > > Diff: https://reviews.apache.org/r/883/diff > > > Testing > ------- > > Added test cases for new api. > > > Thanks, > > Ashutosh > >
