> On 2011-06-22 23:18:43, John Sichi wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 259 > > <https://reviews.apache.org/r/940/diff/1/?file=21412#file21412line259> > > > > Why is this using a Thread instead of a Timer?
Agreed timer is better suited here then Thread. Changed to timer. > On 2011-06-22 23:18:43, John Sichi wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventCleanerThread.java, > > line 33 > > <https://reviews.apache.org/r/940/diff/1/?file=21415#file21415line33> > > > > 6 hrs is actually configurable, right? Yup, it is. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review891 ----------------------------------------------------------- On 2011-06-23 02:55:08, Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/940/ > ----------------------------------------------------------- > > (Updated 2011-06-23 02:55:08) > > > Review request for hive, Carl Steinbach and John Sichi. > > > Summary > ------- > > This addresses HIVE-2225 > > > This addresses bug HIVE-2225. > https://issues.apache.org/jira/browse/HIVE-2225 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1138719 > trunk/conf/hive-default.xml 1138719 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1138719 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1138719 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java > 1138719 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventCleanerTask.java > PRE-CREATION > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartition.java > 1138719 > > Diff: https://reviews.apache.org/r/940/diff > > > Testing > ------- > > updated a test case which exercises this code path. > > > Thanks, > > Ashutosh > >
