[
https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057463#comment-13057463
]
jirapos...@reviews.apache.org commented on HIVE-2194:
-----------------------------------------------------
bq. On 2011-06-27 22:47:07, Paul Yang wrote:
bq. >
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java,
lines 142-144
bq. > <https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line142>
bq. >
bq. > Can we check for equality between origP and the old partition
instead of comparing fields?
The equals() method fails, because the parameter "transient_lastDdlTime" is
sometimes off by one. Otherwise, the two objects are entirely equal. I think
the db name, table name, and list of values also ensures equality.
bq. On 2011-06-27 22:47:07, Paul Yang wrote:
bq. >
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java,
lines 183-194
bq. > <https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line183>
bq. >
bq. > origCols.equals(oldCols)?
Fixed
bq. On 2011-06-27 22:47:07, Paul Yang wrote:
bq. >
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java,
lines 159-161
bq. > <https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line159>
bq. >
bq. > Same here
The equals() method also fails here, even though the tables are logically
equal. In the case above, "tbl" does not have a PrincipalPrivilegeSet.
"oldTable" has a PrincipalPrivilegeSet, but all of it's fields are set to null.
This discrepancy comes from how we get the tables, but I think they should
still be considered equal.
- Sohan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/853/#review920
-----------------------------------------------------------
On 2011-06-21 20:25:04, Sohan Jain wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/853/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-21 20:25:04)
bq.
bq.
bq. Review request for hive and Paul Yang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HIVE-2038 introduced the MetaStoreEventListener abstract class that
defines actions to be performed after particular events on a metastore. Improve
upon that class by adding events to be performed on "alter table" and "alter
partition" actions. Also, update the hive metastore to call the appropriate
functions of the listeners when the events happen.
bq.
bq.
bq. This addresses bug HIVE-2194.
bq. https://issues.apache.org/jira/browse/HIVE-2194
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
1138144
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1138144
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
1138144
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1138144
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java
PRE-CREATION
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java
PRE-CREATION
bq.
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java
1138144
bq.
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
1138144
bq.
bq. Diff: https://reviews.apache.org/r/853/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added test cases to TestMetaStoreEventListener.
bq.
bq.
bq. Thanks,
bq.
bq. Sohan
bq.
bq.
> Add actions for alter table and alter partition events for metastore event
> listeners
> ------------------------------------------------------------------------------------
>
> Key: HIVE-2194
> URL: https://issues.apache.org/jira/browse/HIVE-2194
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Sohan Jain
> Assignee: Sohan Jain
> Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch
>
>
> HIVE-2038 introduced the MetaStoreEventListener abstract class that defines
> actions to be performed after particular events on a metastore. Improve upon
> that class by adding events to be performed on "alter table" and "alter
> partition" actions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
