[ 
https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058840#comment-13058840
 ] 

jirapos...@reviews.apache.org commented on HIVE-306:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/926/
-----------------------------------------------------------

(Updated 2011-07-01 22:40:24.399513)


Review request for hive.


Changes
-------

Fix test case errors for TestParseNegative: missing_overwrite.q and 
TestCliDriver:combine2.q
Unit tests passed for me


Summary
-------

New feature to allow INSERT INTO a table or partition


This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1141339 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1141339 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1141339 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1141339 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
1141339 
  trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION 
  trunk/ql/src/test/results/compiler/errors/missing_overwrite.q.out 1141339 

Diff: https://reviews.apache.org/r/926/diff


Testing
-------


Thanks,

Franklin



> Support "INSERT [INTO] destination"
> -----------------------------------
>
>                 Key: HIVE-306
>                 URL: https://issues.apache.org/jira/browse/HIVE-306
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Zheng Shao
>            Assignee: Franklin Hu
>         Attachments: hive-306.1.patch, hive-306.2.patch, hive-306.3.patch
>
>
> Currently hive only supports "INSERT OVERWRITE destination". We should 
> support "INSERT [INTO] destination".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to