[ https://issues.apache.org/jira/browse/HIVE-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061628#comment-13061628 ]
jirapos...@reviews.apache.org commented on HIVE-2045: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1035/ ----------------------------------------------------------- Review request for hive. Summary ------- review by jvs This addresses bug HIVE-2045. https://issues.apache.org/jira/browse/HIVE-2045 Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java 1127457 http://svn.apache.org/repos/asf/hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestTCTLSeparatedProtocol.java 1127457 Diff: https://reviews.apache.org/r/1035/diff Testing ------- Thanks, John > TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() throws Null > Pointer Exception in some cases > ------------------------------------------------------------------------------------------------------ > > Key: HIVE-2045 > URL: https://issues.apache.org/jira/browse/HIVE-2045 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers > Affects Versions: 0.7.0 > Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise > Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5). > Reporter: Chinna Rao Lalam > Assignee: Chinna Rao Lalam > Attachments: HIVE-2045.patch > > > 1) In TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() is doing > null check for the tokenizer. > If tokenizer is null, fillTokenizer() method is called to get the tokenizer > object. But fillTokenizer() method also can update the tokenizer with NULL , > so NULL check should be done before using the tokenizer. > 2) Also improved some logging in TCTLSeparatedProtocol.java -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira