[
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061702#comment-13061702
] jirapos...@reviews.apache.org commented on HIVE-2210: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1039/#review997 ----------------------------------------------------------- http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java <https://reviews.apache.org/r/1039/#comment2062> update comment http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java <https://reviews.apache.org/r/1039/#comment2059> Use TableType.VIRTUAL_VIEW.toString() instead of literal. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java <https://reviews.apache.org/r/1039/#comment2064> comment says DROP http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q <https://reviews.apache.org/r/1039/#comment2084> For completeness, can you add a SELECT statement to make sure it's still possible to query the renamed view? It's OK if it returns no results, just that semantic analysis passes. - John On 2011-07-07 22:35:58, Charles Chen wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1039/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-07-07 22:35:58) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. ------- bq. bq. https://issues.apache.org/jira/browse/HIVE-2210 bq. bq. bq. This addresses bug HIVE-2210. bq. https://issues.apache.org/jira/browse/HIVE-2210 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1143958 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1143958 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1143958 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1143958 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1143958 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1143958 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/1039/diff bq. bq. bq. Testing bq. ------- bq. bq. Relevant unit tests looked ok bq. bq. bq. Thanks, bq. bq. Charles bq. bq. > ALTER VIEW RENAME > ----------------- > > Key: HIVE-2210 > URL: https://issues.apache.org/jira/browse/HIVE-2210 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Affects Versions: 0.6.0 > Reporter: John Sichi > Assignee: Charles Chen > Attachments: HIVE-2210v0.patch > > > ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW > RENAME. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
