----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1014/#review1036 -----------------------------------------------------------
Changes look good. Is it possible to add a testcase? If not, can you update the jira how it is tested? - Amareshwari On 2011-07-06 00:45:12, Jakob Homan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1014/ > ----------------------------------------------------------- > > (Updated 2011-07-06 00:45:12) > > > Review request for hive. > > > Summary > ------- > > Currently when ExecDriver encounters a non-existent partition, it creates an > empty file so that the query will be valid (and return 0 results). However, > when it does this and calls getHiveRecordWriter(), it creates a new instance > of Properties, rather than providing the Properties associated with the table. > > This causes RecordWriters that pull information from the table through the > Properties to fail (such as Haivvreo). The RecordWriter should be provided > the table's Properties, as it is in all other cases where it's called. > > > This addresses bug HIVE-2260. > https://issues.apache.org/jira/browse/HIVE-2260 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 4fba845 > > Diff: https://reviews.apache.org/r/1014/diff > > > Testing > ------- > > > Thanks, > > Jakob > >
